feat(ui): Add dedicated cron jobs management page #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CronJobsView.vue with full CRUD for scheduled tasks - Support both command and backup task types - Add search, filter by deployment/type, and pagination - Show execution history with output/error details - Add route /cron-jobs and navigation in System group - Uses existing schedulerApi endpoints (no agent changes) Signed-off-by: nfebe <fenn25.fn@gmail.com>
Add comprehensive test suite covering view structure, data loading, filtering, pagination, modal interactions, task actions, execution history, and form validation. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Deploying flatrun-ui with
|
| Latest commit: |
d73c475
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://932ada10.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feature-cron-jobs-page.flatrun-ui.pages.dev |
Code Review Summary✨ This PR introduces a new 🚀 Key Improvements
💡 Minor Suggestions
|
- Add CronJobForm interface for form object - Replace magic numbers with named constants for pagination and API limits (PAGE_SIZE, RECENT_EXECUTIONS_LIMIT, TASK_HISTORY_LIMIT)
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Comment on lines
+690
to
+717
| const cronToHuman = (expr: string): string => { | ||
| const parts = expr.split(" "); | ||
| if (parts.length !== 5) return "Invalid cron expression"; | ||
|
|
||
| const [minute, hour, dayOfMonth, month, dayOfWeek] = parts; | ||
|
|
||
| if (minute === "0" && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | ||
| return "Every hour"; | ||
| } | ||
| if (minute === "*" && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | ||
| return "Every minute"; | ||
| } | ||
| if (dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | ||
| if (minute !== "*" && hour !== "*") { | ||
| return `Daily at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | ||
| } | ||
| if (minute !== "*" && hour === "*") { | ||
| return `Hourly at minute ${minute}`; | ||
| } | ||
| } | ||
| if (dayOfWeek === "0" && dayOfMonth === "*" && month === "*") { | ||
| return `Weekly on Sunday at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | ||
| } | ||
| if (dayOfMonth === "1" && month === "*" && dayOfWeek === "*") { | ||
| return `Monthly on the 1st at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | ||
| } | ||
|
|
||
| return expr; |
There was a problem hiding this comment.
The cronToHuman function can be enhanced to provide more explicit human-readable descriptions for common cron patterns, especially those involving */N (e.g., "every 5 minutes"). The current implementation might return the raw cron string for such patterns or provide a less precise description like "Hourly at minute */5". Refining the logic to prioritize these common expressions will improve user experience.
Suggested change
| const cronToHuman = (expr: string): string => { | |
| const parts = expr.split(" "); | |
| if (parts.length !== 5) return "Invalid cron expression"; | |
| const [minute, hour, dayOfMonth, month, dayOfWeek] = parts; | |
| if (minute === "0" && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| return "Every hour"; | |
| } | |
| if (minute === "*" && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| return "Every minute"; | |
| } | |
| if (dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| if (minute !== "*" && hour !== "*") { | |
| return `Daily at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | |
| } | |
| if (minute !== "*" && hour === "*") { | |
| return `Hourly at minute ${minute}`; | |
| } | |
| } | |
| if (dayOfWeek === "0" && dayOfMonth === "*" && month === "*") { | |
| return `Weekly on Sunday at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | |
| } | |
| if (dayOfMonth === "1" && month === "*" && dayOfWeek === "*") { | |
| return `Monthly on the 1st at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | |
| } | |
| return expr; | |
| const cronToHuman = (expr: string): string => { | |
| const parts = expr.split(" "); | |
| if (parts.length !== 5) return "Invalid cron expression"; | |
| const [minute, hour, dayOfMonth, month, dayOfWeek] = parts; | |
| // Every minute | |
| if (minute === "*" && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| return "Every minute"; | |
| } | |
| // Every N minutes | |
| if (minute.startsWith("*/") && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| const interval = parseInt(minute.substring(2)); | |
| if (!isNaN(interval) && interval > 0) return `Every ${interval} minutes`; | |
| } | |
| // Every hour (at minute 0) | |
| if (minute === "0" && hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| return "Every hour"; | |
| } | |
| // Every N hours (at minute 0) | |
| if (minute === "0" && hour.startsWith("*/") && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| const interval = parseInt(hour.substring(2)); | |
| if (!isNaN(interval) && interval > 0) return `Every ${interval} hours`; | |
| } | |
| // Hourly at specific minute | |
| if (hour === "*" && dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| return `Hourly at minute ${minute}`; | |
| } | |
| // Daily at specific time | |
| if (dayOfMonth === "*" && month === "*" && dayOfWeek === "*") { | |
| return `Daily at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | |
| } | |
| // Weekly on Sunday at specific time | |
| if (dayOfWeek === "0" && dayOfMonth === "*" && month === "*") { | |
| return `Weekly on Sunday at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | |
| } | |
| // Monthly on the 1st at specific time | |
| if (dayOfMonth === "1" && month === "*" && dayOfWeek === "*") { | |
| return `Monthly on the 1st at ${hour.padStart(2, "0")}:${minute.padStart(2, "0")}`; | |
| } | |
| return expr; | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.