fix(api): Generate env vars for existing database mode#114
Merged
Conversation
Code Review SummaryThe PR correctly implements mandatory credential checks for databases in 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
nfebe
force-pushed
the
fix/existing-db-credentials
branch
from
3931a87 to
e2c2e40
Compare
The existing database path was not generating environment variables or writing credentials to .env.flatrun. Validation now requires database_name, username, and password since we lack admin access to create them on an existing database. Port defaults are explicit per database type (mysql, mariadb, postgres, mongodb, redis) with a logged fallback for unknown types. Deployment name sanitization handles hyphens, dots, and spaces. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/existing-db-credentials
branch
from
e2c2e40 to
7d9d6ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require db credentials for existing databases as there is no other way to connect them