fix(ssl): Regenerate vhost after certificate request#113
Merged
Conversation
Code Review SummaryThis PR fixes an issue where SSL certificates were requested but not immediately applied to the Nginx virtual host configuration. It adds an optional 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
When requesting a certificate via POST /certificates, the vhost was not regenerated with SSL configuration. This required manually toggling SSL off/on to trigger vhost update. Now accepts an optional deployment field and directly looks up the deployment to enable SSL and regenerate the vhost after a successful certificate request. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/ssl-vhost-regeneration
branch
from
3b490c0 to
0e6684f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requesting a certificate via POST /certificates, the vhost was not regenerated with SSL configuration. This required manually toggling SSL off/on to trigger vhost update. Now the handler enables SSL on the domain config and regenerates the vhost automatically after a successful certificate request.