fix(nginx): Add default server block for welcome page #102
Merged
Conversation
The nginx template had no server block in conf.d/, so port 80 returned connection reset on fresh installs. Added default.conf serving the welcome page from /usr/share/nginx/html. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThis PR introduces a default Nginx server configuration to serve a welcome page. It includes the configuration file, metadata registration, and updates the Go embed directives to include the new file. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| index index.html; | ||
|
|
||
| location / { | ||
| try_files $uri $uri/ =404; |
There was a problem hiding this comment.
When serving a static welcome page in a containerized or template-based environment, it is often better to fall back to index.html for SPAs or simply serve the index rather than returning a 404 if the exact URI is missing. However, if this is strictly for a static landing page, changing =404 to /index.html can improve user experience for trailing slash mismatches.
Suggested change
| try_files $uri $uri/ =404; | |
| + try_files $uri $uri/ /index.html; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.