Skip to content

builder-module: Abort on invalid module names#715

Open
bbhtt wants to merge 1 commit intomainfrom
bbhtt/validatemodulename
Open

builder-module: Abort on invalid module names#715
bbhtt wants to merge 1 commit intomainfrom
bbhtt/validatemodulename

Conversation

@bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Mar 11, 2026

This goes a step above 6d1d972 and makes it an actual error. The name is used to construct paths in various places

This goes a step above 6d1d972 and
makes it an actual error. The name is used to construct paths in
various places
@swick
Copy link
Contributor

swick commented Mar 11, 2026

The only question I have is if this will break some manifests? Or would there be errors later on anyway?

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 11, 2026

Yes looks like it errors later anyway:

flatpak-builder build --force-clean --user test.yaml
Module names like 'hell/o' containing '/' are problematic. Expect errors.
Emptying app dir 'build'
Downloading sources
Starting build of org.flatpak.hello
Cache miss, checking out last cache hit
Error: module hell/o: Error creating directory /home/bbhtt/Git/github/flatpaks/test/.flatpak-builder/build/hell/o-1: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants