Skip to content

builder-flatpak-utils: Normalize the single trailing slash in pattern#677

Merged
bbhtt merged 2 commits intomainfrom
bbhtt/normalise-trailing-slash
Apr 7, 2026
Merged

builder-flatpak-utils: Normalize the single trailing slash in pattern#677
bbhtt merged 2 commits intomainfrom
bbhtt/normalise-trailing-slash

Conversation

@bbhtt
Copy link
Copy Markdown
Contributor

@bbhtt bbhtt commented Sep 23, 2025

Fixes #476

@bbhtt bbhtt force-pushed the bbhtt/normalise-trailing-slash branch from ced12ee to 029ee89 Compare September 23, 2025 13:53
@bbhtt bbhtt requested a review from TingPing February 25, 2026 03:29
@bbhtt bbhtt added this to the 1.5.0 milestone Mar 9, 2026
@bbhtt bbhtt force-pushed the bbhtt/normalise-trailing-slash branch from 029ee89 to 196eb82 Compare April 2, 2026 11:47
@bbhtt
Copy link
Copy Markdown
Contributor Author

bbhtt commented Apr 2, 2026

any comments on this?

Comment thread src/builder-flatpak-utils.c
@swick
Copy link
Copy Markdown
Contributor

swick commented Apr 2, 2026

Not sure if I would consider this a bug in the first place. Kind of depends on what you consider a path prefix I guess.

@bbhtt
Copy link
Copy Markdown
Contributor Author

bbhtt commented Apr 3, 2026

according to the man, patterns are taken to be either the full pathname or basename, not normalising is a bit weird. it also accepts /*. the patterns are also path-like syntactically.

@bbhtt bbhtt force-pushed the bbhtt/normalise-trailing-slash branch 2 times, most recently from 47d8312 to cd9d281 Compare April 6, 2026 11:50
Comment thread src/builder-flatpak-utils.c
@bbhtt bbhtt force-pushed the bbhtt/normalise-trailing-slash branch from cd9d281 to 4ea0b2f Compare April 7, 2026 14:09
@bbhtt bbhtt removed the request for review from TingPing April 7, 2026 16:23
@bbhtt bbhtt merged commit c610181 into main Apr 7, 2026
3 checks passed
@bbhtt bbhtt deleted the bbhtt/normalise-trailing-slash branch April 7, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: cleanup directive in manifest does not delete directories ending with /

2 participants