fix(node): pnpm - support v10 offline tarballs for URL dependencies#517
fix(node): pnpm - support v10 offline tarballs for URL dependencies#517tonur wants to merge 1 commit intoflatpak:masterfrom
Conversation
|
you have to drop the first commit and rebase properly not sure where that is coming from. and rest should be squahsed where it make sense or prefixed with |
|
you have to run format+lint+typecheck it is documented in readme. is it possible to add tests for this as well? |
cdc4a2d to
5f0a223
Compare
|
I followed the readme to fix linting and syntax. I will have a look at adding tests later tonight. |
|
can you clean the commit history? Why is poetry.lock getting updated here? And there are a bunch of line length changes, if those aren't done by |
Sorry, my editor was configured to cleanup on save, I have turned it off and reverted this. With clean commit history, I would ask if the current is sufficient? Otherwise, I'd like to hear what you want me to do, as I do not know how a clean commit history would look then. |
|
something is blocking me pushing to your branch, i will fix the commit message and authorship and merge it manually. |
This PR adds support for generating offline pnpm store entries for packages retrieved from URL tarballs (e.g., GitHub codeload links) in pnpm v10.
It now parses
package.jsonfrom inside downloaded tarballs to extract the actualnameandversionfields, which pnpm v10 strictly requires for offline resolution.Updates the cache index directory structure to match pnpm v10's expected format for URL dependencies (using the sanitized URL directory and
integrity.json).Safely generates tarball filenames for URLs by using a SHA-256 hash to avoid filesystem path issues with special characters.
Made based on the Stoat flathub submission: flathub/flathub#7783