-
Notifications
You must be signed in to change notification settings - Fork 2
2.0.9/2.1.0 test builds (do not merge yet) #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
|
@Calinou From the build log I noticed a new tessfont_linux binary is now being created. I remember I and AsciiWolf agreed to keep/ship all Red Eclipse binaries in the Flatpak, but I don't really understand what this new tessfont_linux binary does exactly. Is it going to be useful in the Flatpak? Also, does RE support controllers or Steam Deck controls? I just noticed it has the |
|
Otherwise, just tested this a bit, seems to work fine. |
It's not only about Steam Deck controllers, but about gamepad support as a whole. And Red Eclipse should support gamepads - if I am not wrong, I actually tried this before enabling the all devices permission. The new |
Interesting, I thought |
|
Well, I think that I am also not happy about the |
|
Yeah, fair points. |
It's only useful for modders wishing to port fonts to the game, so you probably don't need to include it. |
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Fedora 42, it works as expected.
Yeah, it looks like it will also need filesystem access in order to be useful, so I leave it as is. |
|
By the way, keep in mind that for the actual release, version information in AppStream metadata need to be updated too. |
|
Yes, I'm aware. |
|
🚧 Test build enqueued. |
1 similar comment
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
|
I've made some upstream metadata improvements which got accepted, so I'm bringing them here as well. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
…the upstream ones It should be possible to exclusively use upstream flags this way too.
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. Help
|
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. |
|
Looks good! Thanks again for your work on the Red Eclipse Flatpak. :-) We should probably move it to "Draft" though and switch it to "Ready" after the 2.1.0 gets released. |
|
Sure, you can turn the PR into a draft. Though it seems to me version 2.1.0 gets delayed quite a lot, so in case it won't be released before 26.08, I think we should just turn this into a runtime update PR and merge it because it also contains other improvements. Regarding the last 2 commits from yesterday, I was just trying to see whether it's possible to use the upstream compile flags exclusively, without explicitly setting them in the manifest (because setting them in the manifest means we'll have to monitor the makefile for future changes in the primary flags). But the 2 options I tried don't work properly, so I opened another upstream PR to fix that in the makefile. |
I opened this PR to test the latest 2.0.9 builds and see if something needs to be adjusted for the upcoming 2.1.0 release.
After 2.1.0 is released, we can update to it via this PR and merge it.