refactor: extract post-seal side-effects into PostSealHook trait#518
Open
julio4 wants to merge 1 commit into
Open
refactor: extract post-seal side-effects into PostSealHook trait#518julio4 wants to merge 1 commit into
julio4 wants to merge 1 commit into
Conversation
Move WS publication, p2p forwarding, engine propagation, and per-flashblock metrics out of the building loop and behind a PostSealHook trait. Hooks are constructed once in OpPayloadBuilder::new() and dispatched after each sealed candidate (fallback + every flashblock). build_next_flashblock no longer performs side-effects: it returns a FlashblockBuildResult struct and the async loop handles dispatch. The side-effect call sites in the fallback path and the FB iteration are collapsed to a single dispatch_post_seal call each. p2p and engine forwarders are unified as ChannelHook(name, sender) since they only differ in the failure log label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ws publication, p2p forwarding, engine propagation, and per-flashblock metrics out of the building loop behind a
PostSealHooktrait. Hooks are constructed once and dispatched after each sealed candidate (fallback + every flashblock).build_next_flashblockno longer performs side-effects: it returnsFlashblockBuildResultstruct and the async loop handles dispatch.