fix: replace *http.Request in log field with JSON-safe fields#896
Closed
seeforschauer wants to merge 1 commit into
Closed
fix: replace *http.Request in log field with JSON-safe fields#896seeforschauer wants to merge 1 commit into
seeforschauer wants to merge 1 commit into
Conversation
Fixes flashbots#894. *http.Request contains GetBody func() which encoding/json cannot marshal. When using JSON log format (-json flag), logrus silently drops the log entry. Replace the raw request with method, url, and content-type fields.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Replace raw
*http.Requeststruct in logrus field with individual JSON-serializable fields (method,url,contentType).*http.RequestcontainsGetBody func() (io.ReadCloser, error)whichencoding/jsoncannot marshal. When mev-boost runs with-jsonflag, logrusJSONFormatterfails to serialize the field and silently drops the log entry.Root Cause
server/register_validator.go:51passed the full request struct:Fix
Extract the useful fields instead:
Fixes #894.
Testing
go build ./...— passesgo test ./server/...— all pass