Skip to content

feat(rpcserver): add INFO level request logging #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odysseus0 merged 1 commit into from
Feb 5, 2026
Merged

feat(rpcserver): add INFO level request logging #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions rpcserver/jsonrpc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,31 @@ func (h *JSONRPCHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
startAt := time.Now()
methodForMetrics := unknownMethodLabel
bigRequest := false
hasError := false
ctx := r.Context()
ctx = context.WithValue(ctx, requestKey{}, r)

defer func() {
incRequestCount(methodForMetrics, h.ServerName, bigRequest)
incRequestDuration(time.Since(startAt), methodForMetrics, h.ServerName, bigRequest)

// Log request at INFO level for observability
if h.Log != nil && methodForMetrics != unknownMethodLabel {
duration := time.Since(startAt)
if hasError {
h.Log.Info("Request completed",
slog.String("method", methodForMetrics),
slog.Duration("duration", duration),
slog.String("status", "error"),
slog.String("server", h.ServerName))
} else {
h.Log.Info("Request completed",
slog.String("method", methodForMetrics),
slog.Duration("duration", duration),
slog.String("status", "ok"),
slog.String("server", h.ServerName))
}
}
}()

stepStartAt := time.Now()
Expand Down Expand Up @@ -386,6 +405,7 @@ func (h *JSONRPCHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// call method
result, err := method.call(ctx, req.Params)
if err != nil {
hasError = true
if jsonRPCErr, ok := err.(*JSONRPCError); ok {
h.writeJSONRPCErrorWithData(w, req.ID, jsonRPCErr.Code, jsonRPCErr.Message, jsonRPCErr.Data)
} else {
Expand Down