Skip to content

Conversation

@Peponks9
Copy link
Contributor

@Peponks9 Peponks9 commented Jan 6, 2026

closes #411

open for feedback :)

cc @zeroXbrock

@Peponks9 Peponks9 requested a review from zeroXbrock as a code owner January 6, 2026 04:56
- we were using String and manually parsing to Url,
  might as well just save the Url
- this also resolves problems arising out of non-exact matches,
  e.g. "http://localhost:8545" and "http://localhost:8545/"
@zeroXbrock
Copy link
Member

thanks @Peponks9, nice work!
I just made a minor adjustment: I realized we were using String for urls in a lot of places where we should have been using url::Url, so I went ahead and refactored all the urls. Serde can parse Urls natively so we don't have to worry about parsing the strings ourselves, and storing urls this way prevents slightly-differently-formatted rpc URLs (like a trailing slash) from screwing up the admin contract-address request.

@zeroXbrock zeroXbrock merged commit 4c6e134 into flashbots:main Jan 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

admin subcommand: lookup contract address

2 participants