CI: on release, push docker image #123
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub Actions job to build and push a Docker image to GitHub Container Registry when a release is created. The job is triggered on push events or when a manual workflow dispatch includes the build-docker input set to true.
Changes:
- Added a new
build-dockerjob that builds and pushes a multi-platform Docker image - Configured Docker metadata extraction to generate appropriate semantic version tags
- Set up GitHub Container Registry authentication using the GitHub token
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| type=semver,pattern={{major}} |
There was a problem hiding this comment.
The semver tag types require the VERSION environment variable to be passed to the metadata-action. Without adding flavor: latest=auto and passing the version as a label or using type=semver with a value parameter, these patterns won't generate tags correctly. Consider adding the VERSION as input to the metadata extraction step.
| type=semver,pattern={{version}} | |
| type=semver,pattern={{major}}.{{minor}} | |
| type=semver,pattern={{major}} | |
| type=semver,pattern={{version}},value=${{ env.VERSION }} | |
| type=semver,pattern={{major}}.{{minor}},value=${{ env.VERSION }} | |
| type=semver,pattern={{major}},value=${{ env.VERSION }} |
| type=semver,pattern={{version}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| type=semver,pattern={{major}} | ||
| type=sha,prefix= |
There was a problem hiding this comment.
The empty prefix for the SHA tag type creates tags without any indicator that they're commit SHAs (e.g., just 'abc123'). Consider using a prefix like 'sha-' to make these tags more identifiable (e.g., 'sha-abc123').
| type=sha,prefix= | |
| type=sha,prefix=sha- |
ameba23
left a comment
ameba23
left a comment
There was a problem hiding this comment.
Great to have this in! 💯
I made a test release on this branch and can confirm i was able to docker pull ghcr.io/flashbots/attested-tls-proxy:baca665
Feel free to delete the test release and associated container.
Probably it is worth addressing the issues copilot flagged as i checked it over with chatgpt and it also mentioned something about releases named directly as hashes without a sha- prefix may be unintentionally marked as "latest". 🤷
2 participants
Build Docker image, and push to Github container registry