fix: filter unlisted pages from llms.txt when sitemap fallback is used#1401
Open
prajakta128 wants to merge 2 commits into
Open
fix: filter unlisted pages from llms.txt when sitemap fallback is used#1401prajakta128 wants to merge 2 commits into
prajakta128 wants to merge 2 commits into
Conversation
Author
|
Hi, I have submitted PR #1401 for review. This fix addresses Could you please:
Summary of changes:
No new dependencies have been added. There is no behavior PR: #1401 Please let me know if you have any questions or require Thank you. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where pages marked
unlisted: truein frontmatter were never filtered out of generatedllms.txtfiles when the sitemap fallback path was used.The issue was caused because
buildReplacementsAndUnlisted()correctly returned bothreplacementsandunlistedPaths, butmain()only extractedreplacements. As a result, the computedunlistedPathsset was discarded before it could be used during pruning.Problematic code:
Fixed code:
This bug is silent in production environments where
sitemap.xmlexists, but it becomes active in local development and partial CI builds that rely on theglobalData.jsonfallback path.Changes included:
unlistedPathsthroughmain()pruneAndMarkdownify()signature to acceptunlistedPathsunlistedPaths.has(route)filtering logicprocessLlmsTxt()signature and call sites to passunlistedPathsNo new dependencies added. No behavior change when
sitemap.xmlis present.