Updated for latest macosx#470
Open
johnhe4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced GNU-specific
--no-as-neededwithCMAKE_LINK_WHAT_YOU_USE. Unfortunately cmake still doesn't do the right thing so also checked if GNU compiler is used or notAdded the include directory for LZ4 since
/usr/local/*isn't included by cmake on MacUsing the full path for linking LZ4 for same reason as Matlab installation not found even if it is in the path #2
Not fully tested but does build on latest Mac (1.15.7) with Apple clang version 12.0.0 (clang-1200.0.32.27)