fix: don't push Docker images on pull requests#27
Merged
adityathebe merged 1 commit intomainfrom Nov 6, 2025
Merged
Conversation
The build-and-test workflow was pushing Docker images to ghcr.io on every pull request, which wastes registry storage and CI resources. This change makes the push conditional so that: - Pull requests: build and test only (no push) - Main branch pushes: build, test, and push - Version tags: build, test, and push - Manual workflow dispatch: build, test, and push This aligns with the pattern used in mission-control repository.
Member
Author
|
this has been reversed in #25 we need to push the image for each pr for the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only push images on main/tags, not PRs