refactor: introduce PipelineRun aggregate for runner-planner protocol#904
Merged
Merged
Conversation
Replace the (List<AbstractLoadedStage>, ExecutionResultBuilder) pair carried through the runner with a single mutable aggregate (PipelineRun) that owns in-flight state and produces the ExecuteResponseData. - New `internal.core.pipeline.run`: **PipelineRun**, **StageRun**, **StageState** (polymorphic; Failed carries ErrorInfo). - API change: `ExecutionPlanner.getNextExecution(List<AbstractLoadedStage>)` → `getNextExecution(PipelineRun)`. CommunityExecutionPlanner and CloudExecutionPlanner migrated. - Intent-named mutators: `markStageStarted`, `markStageCompleted(result)`, `markStageFailed(exception)` — aggregate derives ErrorInfo from StageExecutionException. - Removed **ExecutablePipeline** (trivial wrapper) and **ExecutionResultBuilder**; ExecutionPlan holds `List<ExecutableStage>` directly; `PipelineRun.toResponse()` builds the report. No observable behavior change: runner still fail-fasts on StageExecutionException; response shape and event firing points are identical.
dieppa
force-pushed
the
refactor/pipeline_run_execution_planner
branch
from
46ed57f to
481d3aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify in-flight state and reporting under a single mutable aggregate (PipelineRun), removing
the parallel
ExecutionResultBuilderbookkeeping the runner used alongside the planner.New (
internal.core.pipeline.run):PipelineRun— aggregate root; one StageRun per stage, timing, and the single sourceof truth for
ExecuteResponseDataviatoResponse(). Mutators go throughmarkStageState(name, state, result?).StageRun— per-stage holder: loaded stage + current state + optionalStageResult.Package-private setters; only PipelineRun mutates.
StageState— polymorphic (NOT_STARTED / STARTED / COMPLETED / Failed);Failedcarries the
ErrorInfo.isFailed()/getErrorInfo()replace the previousenum + optional pairing.
Breaking API change for
ExecutionPlannerimplementors:getNextExecution(List<AbstractLoadedStage>)→getNextExecution(PipelineRun). BothCommunityExecutionPlannerandCloudExecutionPlannermigrated; bodies unchanged(they read loaded stages via
pipelineRun.getLoadedStages()). Per-stage stateconsumption is deferred to a later phase.
Removed:
ExecutablePipeline— trivial wrapper;ExecutionPlannow holdsList<ExecutableStage>directly and absorbsgetExecutableStages()/isExecutionRequired().ExecutionResultBuilder— its responsibilities (stage accumulation, timing,pipeline-level error) move onto PipelineRun; the response is produced by
toResponse().No observable behavior change: runner still fail-fasts on
StageExecutionException;response shape, event firing points, and payloads are identical to today. Unblocks the next
phase (stop fail-fasting across stages) by giving the runner one place to record outcomes
and one call to materialize the final report.