Open
Conversation
Member
dieppa
commented
May 8, 2026
dieppa
commented
- refactor: incremental builds(phase1)
- refactor: incremental builds(phase1)
- refactor(processor): RoundInputs stores nullable fields, exposes Optional only via getters
- refactor: phase 2
- refactor: gradle plugin triger compilation when .yaml is changed
- refactor: triger plugin version
- refactor: improve code quality
- test: more tests
- refactor: incremental build multimodule legacy support
- fix: multimodule yaml resolution
- refactor: kapt and graalvm for spring
…onal only via getters Storing `Optional` as fields and accepting them as constructor parameters is the anti-pattern Brian Goetz explicitly warned against (and that IntelliJ and SonarQube flag). The recommended pattern is to store nullable references directly and return `Optional` only from getters. - `enableAnnotation` and `builderProvider` are now nullable fields (`EnableFlamingock`, `BuilderProviderInfo`) instead of `Optional<...>`. - Constructor accepts nullable values directly; `RoundDiscovery` unwraps `AnnotationFinder`'s returned `Optional`s with `.orElse(null)` at the call site. - Getters keep returning `Optional<...>` (the recommended use of `Optional` — method return types) so all existing call sites in the processor's phase methods compile unchanged. - `isEmpty()` updated to use null checks instead of `isPresent()`. No behavioural change; full test suite remains green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.