Polish Cursor native tool replay parity#8
Closed
fitchmultz wants to merge 4 commits into
Closed
Conversation
Inherited env from pi sessions caused false failures when asserting Agent.create local options. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globactivity through native pifindcards instead of fake bash-styleglobcards.Supersedes closed #7 with a narrower, per-tool audited change set.
Visual + JSONL evidence
Captured offscreen with
node-pty + xterm.js + Playwright, no focused Terminal/screencapture.Gallery:
/tmp/pi-visual-harness/review-current/review-gallery.png/tmp/pi-visual-harness/review-current/review-gallery.htmlPer-case evidence:
/tmp/pi-visual-harness/review-current/before-glob-single.png/tmp/pi-visual-harness/review-current/after-glob-single.png/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-28-13-846Z_019e45c9-7f95-706f-b198-0bfbfe69ac9f.jsonl/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-30-22-408Z_019e45cb-75c8-769a-a43b-d947c62bd6f2.jsonl/tmp/pi-visual-harness/review-current/before-empty-glob.png/tmp/pi-visual-harness/review-current/after-empty-glob.png/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-24-24-635Z_019e45c6-003b-7023-8b17-748ac1db1417.jsonl/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-24-43-564Z_019e45c6-4a2c-7875-8548-2e9810f125e3.jsonl/tmp/pi-visual-harness/review-current/before-empty-grep.png/tmp/pi-visual-harness/review-current/after-empty-grep.png/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-25-02-753Z_019e45c6-9521-768c-917e-9226322e5c55.jsonl/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-25-21-664Z_019e45c6-df00-705f-955f-29dd0ed2621a.jsonl/tmp/pi-visual-harness/review-current/before-shell-nonzero.png/tmp/pi-visual-harness/review-current/after-shell-nonzero.png/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-25-40-589Z_019e45c7-28ed-7888-a51d-b687b56eafdd.jsonl/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-30-43-364Z_019e45cb-c7a4-7871-9344-96be77a85ce1.jsonl/tmp/pi-visual-harness/review-current/before-shell-timeout.png/tmp/pi-visual-harness/review-current/after-shell-timeout.png/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-26-18-488Z_019e45c7-bcf8-72d5-8d59-411e4eae1dc9.jsonl/Users/mitchfultz/.pi/agent/sessions/--Users-mitchfultz-Projects-AI-pi-semantic-code-intelligence--/2026-05-20T14-26-39-407Z_019e45c8-0eaf-7d43-9ff1-f652e79228e3.jsonlJSONL spot-checks:
glob-single: beforetoolCall.name=bashwithcommand: glob ...; aftertoolCall.name=findwithpattern: src/tools/reindex.ts.empty-glob: before raw{ files: [], totalFiles: 0 }; afterNo files found matching pattern.empty-grep: before raw nestedworkspaceResults; after(no matches).shell-nonzero: beforetoolResult.isError=false; aftertoolResult.isError=true.shell-timeout: after first shell replay istoolResult.isError=truewithCommand backgrounded after 1 second timeout.Validation
npm test— 154 passednpm run typecheckgit diff --check