FCE-3322: Fix react native MediaStreamTrack#539
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes React Native type leakage by ensuring the mobile client surfaces React Native WebRTC media types (not DOM/web types) through its public hook results and track objects.
Changes:
- Re-export
MediaStreamTrackfrom@fishjam-cloud/react-native-webrtcvia the mobile client entrypoint. - Update mobile override types (
Track,RemoteTrack, and device hook results) sotrack,videoTrack,audioTrack, andstartCamera/startMicrophonereturns are typed asRNMediaStreamTrack. - Move
MiddlewareResult/TrackMiddleware/TracksMiddleware/TracksMiddlewareResultexports to the mobile override types and adapt hook wrappers to accept RN-typed middleware.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/mobile-client/src/overrides/types.ts | Switches public mobile override types from web MediaStreamTrack to RN MediaStreamTrack, and defines RN-typed middleware/result types. |
| packages/mobile-client/src/overrides/hooks.ts | Wraps middleware setters and casts hook results so consumers see RN media types for tracks and middleware. |
| packages/mobile-client/src/index.ts | Re-exports MediaStreamTrack from RN WebRTC and re-exports middleware types from the mobile overrides instead of the web client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MediaStreamTrackfrom@fishjam-cloud/react-native-webrtcso mobile consumers get the RN-native track type.TrackandRemoteTrackso theirtrackfield is typed asRNMediaStreamTrackinstead of the web type.useCamera,useMicrophone,useScreenShareresults (and middleware types) to use RN media types forstartCamera/startMicrophonereturns,videoTrack/audioTrack, and*Middlewaresetters.MiddlewareResult,TrackMiddleware,TracksMiddleware,TracksMiddlewareResultexports to the mobile overrides.Motivation and Context
The mobile client was leaking the web
MediaStreamTracktype through hooks and track objects, causing type mismatches for RN consumers. This aligns all media track types withreact-native-webrtc.Documentation impact
Types of changes
not work as expected)