-
Notifications
You must be signed in to change notification settings - Fork 2
FCE-2497: Set proper sdkVersion #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the mobile app was incorrectly reporting itself as using the web SDK version. It introduces a ClientType type with two options ('web' | 'mobile') and adds the ability to set the client type when creating a FishjamClient. The mobile SDK now correctly hardcodes the clientType to 'mobile', ensuring accurate SDK version reporting.
Changes:
- Added
ClientTypetype andclientTypeoptional parameter to SDK configuration - Updated FishjamClient to use configurable clientType when constructing the sdkVersion string
- Hardcoded clientType to 'mobile' in the mobile-client FishjamProvider wrapper
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ts-client/src/types.ts | Added ClientType type definition and clientType field to CreateConfig |
| packages/ts-client/src/index.ts | Exported ClientType type for public API consumption |
| packages/ts-client/src/FishjamClient.ts | Added clientType property and updated sdkVersion construction to use configurable client type |
| packages/react-client/src/FishjamProvider.tsx | Added clientType prop to FishjamProviderProps and passed it to FishjamClient |
| packages/mobile-client/src/useForegroundService.ts | Cleaned up trailing whitespace in JSDoc comments |
| packages/mobile-client/src/index.ts | Hardcoded clientType to 'mobile' and improved code formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4deeaeb to
b989423
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: adrian <33912477+czerwiukk@users.noreply.github.com>
Description
FishjamProviderMotivation and Context
Documentation impact
Types of changes
not work as expected)