Skip to content

Fix tests#79

Open
roznawsk wants to merge 6 commits intomainfrom
fix-tests
Open

Fix tests#79
roznawsk wants to merge 6 commits intomainfrom
fix-tests

Conversation

@roznawsk
Copy link
Copy Markdown
Member

@roznawsk roznawsk commented May 6, 2026

Description

  • add python 3.14
  • swap localtunnel for instatunnel
  • make the tests run sequentially for each python version
  • make the tests not fail if a single python version tests fail
  • make sure that we only listen for notifications for the given room
  • cleanup room after each test

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CI and the test suite to improve reliability across multiple Python versions by standardizing test fixtures, filtering WebSocket notifications to the room under test, and serializing the test matrix execution.

Changes:

  • Add Python 3.14 to the CI matrix, serialize matrix execution, and switch tunnel provider from localtunnel to instatunnel.
  • Introduce a shared room_api pytest fixture that tracks created rooms and cleans them up after each test.
  • Update notifier tests/utilities to only consume server notifications for the room created within the test.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/test_room_api.py Switches to the shared room_api fixture.
tests/test_notifier.py Passes a room id future into event assertions so notifications are filtered to the active test room.
tests/support/asyncio_utils.py Adds room-scoped filtering/pending buffering to the notification assertion helper.
tests/conftest.py Adds a tracking FishjamClient fixture and post-test room cleanup.
.github/workflows/ci.yml Expands Python matrix, serializes test runs, and swaps localtunnel for instatunnel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_notifier.py Outdated
Comment thread tests/test_notifier.py Outdated
Comment thread tests/test_notifier.py Outdated
Comment thread tests/conftest.py
Comment thread .github/workflows/ci.yml
@roznawsk roznawsk requested a review from Karolk99 May 6, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants