Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI and the test suite to improve reliability across multiple Python versions by standardizing test fixtures, filtering WebSocket notifications to the room under test, and serializing the test matrix execution.
Changes:
- Add Python 3.14 to the CI matrix, serialize matrix execution, and switch tunnel provider from localtunnel to instatunnel.
- Introduce a shared
room_apipytest fixture that tracks created rooms and cleans them up after each test. - Update notifier tests/utilities to only consume server notifications for the room created within the test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_room_api.py |
Switches to the shared room_api fixture. |
tests/test_notifier.py |
Passes a room id future into event assertions so notifications are filtered to the active test room. |
tests/support/asyncio_utils.py |
Adds room-scoped filtering/pending buffering to the notification assertion helper. |
tests/conftest.py |
Adds a tracking FishjamClient fixture and post-test room cleanup. |
.github/workflows/ci.yml |
Expands Python matrix, serializes test runs, and swaps localtunnel for instatunnel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)