Skip to content

chore: install.sh HTML redirect + clippy fix #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firstintent merged 1 commit into from
May 24, 2026
Merged

chore: install.sh HTML redirect + clippy fix #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ccteam-core/src/templates/project_probe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ fn detect_languages_and_tests(repo_root: &Path) -> (Vec<Language>, bool) {
(Language::Go, count_go),
(Language::Java, count_java),
];
ranked.sort_by(|a, b| b.1.cmp(&a.1));
ranked.sort_by_key(|b| std::cmp::Reverse(b.1));
let langs: Vec<Language> = ranked
.into_iter()
.filter(|(_, n)| *n > 0)
Expand Down
22 changes: 18 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# * Strong checksum verification; mismatch aborts non-zero.
# * No sudo. Writes to $HOME/.local/bin by default.
# * Override target dir: CCTEAM_INSTALL_DIR=/usr/local/bin sh install.sh
# * Override tag (CI / pin): CCTEAM_VERSION=v0.6.6 sh install.sh
# * Override tag (CI / pin): CCTEAM_VERSION=<tag> sh install.sh
# * Windows is not supported — run ccteam under WSL2 and use the
# linux-x64 binary (tmux + inotify + POSIX signals are foundational).
#
Expand Down Expand Up @@ -112,29 +112,43 @@ detect_sha256() {
fi
}

# ---- resolve tag: env override → GH API "latest" ----
# ---- resolve tag: env override → HTML redirect (primary) → GH API (fallback) ----
resolve_tag() {
if [ -n "${CCTEAM_VERSION:-}" ]; then
TAG="$CCTEAM_VERSION"
info "Using pinned version: $TAG"
return
fi
info "Resolving latest release..."
# Primary: HTML redirect (no GitHub API rate limit ~60 req/hr per IP).
# github.com/.../releases/latest 302-redirects to /releases/tag/<version>;
# grab the Location header (no -L = don't follow, we only want the redirect target).
TAG="$(curl -sI "https://github.com/$REPO/releases/latest" 2>/dev/null \
| grep -i '^location:' \
| sed -E 's|.*/tag/([^[:space:]]+).*|\1|' \
| tr -d '\r')"
if [ -n "$TAG" ]; then
info "Latest release: $TAG"
return
fi
# Fallback: GitHub API (rate-limited; only hit if HTML redirect parse failed).
info "Redirect parse failed; falling back to GitHub API..."
_api="https://api.github.com/repos/$REPO/releases/latest"
_tmp="$(mktemp)"
if ! download "$_api" "$_tmp"; then
err "failed to query GitHub API: $_api"
err "Override: CCTEAM_VERSION=<tag> sh install.sh"
exit 1
fi
# POSIX grep + sed (no jq dependency).
TAG="$(grep -m1 '"tag_name"' "$_tmp" | sed -E 's/.*"tag_name"[[:space:]]*:[[:space:]]*"([^"]+)".*/\1/')"
rm -f "$_tmp"
if [ -z "$TAG" ]; then
err "could not parse tag_name from GitHub API response"
err "Override: CCTEAM_VERSION=v0.6.6 sh install.sh"
err "Override: CCTEAM_VERSION=<tag> sh install.sh"
exit 1
fi
info "Latest release: $TAG"
info "Latest release (via API fallback): $TAG"
}

# ---- main install ----
Expand Down
Loading