Adding asyncio unit tests#22
Open
bradpenney wants to merge 2 commits into
Open
Conversation
Signed-off-by: Brad Penney <penney.brad@protonmail.com>
Contributor
Author
|
33aa333 to
199dfe5
Compare
011deb5 to
4aa8f81
Compare
ebourgeois
reviewed
Oct 26, 2025
64f3b5b to
d54b76a
Compare
ebourgeois
reviewed
Oct 26, 2025
| def _jsonloader(uri, **kwargs): | ||
| if uri.startswith("file://"): | ||
| uri = uri[8:] | ||
| uri = uri[7:] |
Contributor
Author
There was a problem hiding this comment.
_jsonloadernow stripsfile://URIs withuri[7:]and adds a fallback for plainfile:. The old slice uri[8:] lopped off the first character of absolute paths likefile:///tmp/schema.yaml, so jsonref tried to open tmp/schema.yaml relative to CWD and crashed whenever a schema contained$refs to other local files or when tests exercised those paths.- Guarding the plain
file:case lets jsonref hand us eitherfile:///...orfile:/...and still resolves correctly, which is how coverage tests trigger the loader. - With this correction, nested schema references load reliably whether they arrive with
file:orfile://URIs, eliminating the FileNotFound errors seen in test runs.
Contributor
|
Please update the builds to match these new python version constraints |
5fa1069 to
89a4adf
Compare
Signed-off-by: Brad Penney <penney.brad@protonmail.com>
89a4adf to
1273178
Compare
Contributor
Author
Done! https://github.com/firestoned/firestone-lib/actions/runs/18824634843 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
click.ParamType, including new negative cases and alias checks._jsonloaderURI normalization.