Skip to content

Use URL-state symbol server for profiler-cli function annotate#6051

Open
canova wants to merge 1 commit into
firefox-devtools:mainfrom
canova:pq-asm-symbols
Open

Use URL-state symbol server for profiler-cli function annotate#6051
canova wants to merge 1 commit into
firefox-devtools:mainfrom
canova:pq-asm-symbols

Conversation

@canova
Copy link
Copy Markdown
Member

@canova canova commented May 22, 2026

Fixes #6050

function annotate --mode asm always fell back to the hardcoded http://localhost:3000 when --symbol-server wasn't passed to the annotate command, and ignored both ?symbolServer= from a loaded profiler.firefox.com URL and --symbol-server passed to pq load.

This commit changes the cli to resolve the symbol server inside ProfileQuerier.functionAnnotate via getSymbolServerUrl when no explicit URL is provided, so the value set by either source on the URL state is taken into account. An explicit --symbol-server on function annotate still overrides.

STR:

  • Record a profile using samply
  • Load it with the cli: profiler-cli load <samply profile link that includes the symbol server>
  • Get a function handle in pq thread samples
  • Run pq function annotate <handle>

It should now properly show the assembly without requiring pq function annotate --symbol-server <url>.

`function annotate --mode asm` always fell back to the hardcoded
`http://localhost:3000` when `--symbol-server` wasn't passed to the
annotate command, and ignored both `?symbolServer=` from a loaded
profiler.firefox.com URL and `--symbol-server` passed to `pq load`.

This commit changes the cli to resolve the symbol server inside
`ProfileQuerier.functionAnnotate` via `getSymbolServerUrl` when no
explicit URL is provided, so the value set by either source on the URL
state is taken into account. An explicit `--symbol-server` on `function
annotate` still overrides.
@canova canova requested a review from mstange May 22, 2026 13:02
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.77%. Comparing base (3182970) to head (502b4c8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6051      +/-   ##
==========================================
- Coverage   83.78%   83.77%   -0.01%     
==========================================
  Files         329      329              
  Lines       34528    34547      +19     
  Branches     9659     9574      -85     
==========================================
+ Hits        28930    28943      +13     
- Misses       5169     5175       +6     
  Partials      429      429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

profiler-cli function annotate command doesn't look at the symbol server in the redux state

1 participant