Skip to content

Move some profile fetching code into a separate module#5939

Merged
canova merged 1 commit intofirefox-devtools:mainfrom
canova:fetching-module
Apr 9, 2026
Merged

Move some profile fetching code into a separate module#5939
canova merged 1 commit intofirefox-devtools:mainfrom
canova:fetching-module

Conversation

@canova
Copy link
Copy Markdown
Member

@canova canova commented Apr 9, 2026

This is the first commit of the cli PR: #5663. I thought it would be good to land the earlier commits of it, so it's going to be easier to land that one in the future. This one looks simple enough. It mostly move things around.

This logic can be useful independently of redux actions, for CLI scripts
which want to support profiler URLs.
@canova canova requested a review from mstange April 9, 2026 14:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 69.35484% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.38%. Comparing base (46e3594) to head (3a65387).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/profile-fetch.ts 69.09% 34 Missing ⚠️
src/test/fixtures/utils.ts 62.50% 3 Missing ⚠️
src/actions/receive-profile.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5939      +/-   ##
==========================================
- Coverage   85.45%   85.38%   -0.07%     
==========================================
  Files         321      322       +1     
  Lines       32068    32101      +33     
  Branches     8745     8850     +105     
==========================================
+ Hits        27403    27410       +7     
- Misses       4234     4260      +26     
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova canova merged commit 2486c95 into firefox-devtools:main Apr 9, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants