Fix extractGeckoLogs for structured Log marker format (bug 2022540)#5927
Open
padenot wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Fix extractGeckoLogs for structured Log marker format (bug 2022540)#5927padenot wants to merge 1 commit intofirefox-devtools:mainfrom
padenot wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Bug 2022540 switched Log markers from {module, name} fields to structured
{level, message} fields, with the module name stored as the marker name.
The old format used a single module string that could include the log level
prefix (e.g. D/cubeb); the new format uses an integer level field.
Profiles use one format exclusively, never a mix. We detect which by
checking the first Log marker found in each thread.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5927 +/- ##
==========================================
- Coverage 85.41% 85.41% -0.01%
==========================================
Files 321 321
Lines 32157 32160 +3
Branches 8781 8867 +86
==========================================
+ Hits 27468 27469 +1
- Misses 4253 4255 +2
Partials 436 436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2022540 switched Log markers from {module, name} fields to structured {level, message} fields, with the module name stored as the marker name. The old format used a single module string that could include the log level prefix (e.g. D/cubeb); the new format uses an integer level field.
Profiles use one format exclusively, never a mix. We detect which by checking the first Log marker found in each thread. This also types things a little more.