Make the source table non-optional in the gecko profile format #5842
Open
canova wants to merge 2 commits intofirefox-devtools:mainfrom
Open
Make the source table non-optional in the gecko profile format #5842canova wants to merge 2 commits intofirefox-devtools:mainfrom
canova wants to merge 2 commits intofirefox-devtools:mainfrom
Conversation
This patch changes the gecko profiler format to always include source table. The backend patch also increases the gecko profile format version. Backend bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2016666 This PR has to be deployed before we can land the backend.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5842 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 319 319
Lines 31411 31420 +9
Branches 8670 8575 -95
=======================================
+ Hits 26876 26885 +9
Misses 4104 4104
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend changes for this PR: Bug 2016666
This will allow us to add more fields to the source table, like
sourceMapURLwhich will allow us to resolve source maps.Can't really provide a before and after deploy previews since this requires loading gecko profiles from scratch. Here two profiles with version 32 to test this upgrading:
Version 32 with no source table
Version 32 with source table
You can drag and drop it inside https://deploy-preview-5842--perf-html.netlify.app/