Skip to content

Make markers darker#5839

Merged
mstange merged 3 commits intofirefox-devtools:mainfrom
arai-a:dark-marker
Feb 14, 2026
Merged

Make markers darker#5839
mstange merged 3 commits intofirefox-devtools:mainfrom
arai-a:dark-marker

Conversation

@arai-a
Copy link
Contributor

@arai-a arai-a commented Feb 14, 2026

Fixes #5838

This does:

  • Make jank markers (red markers) darker
    • Make the border colors compatible with light/dark colors
  • Make style markers (teal markers) darker
  • Make regular and highlighted samples markers (blue markers) darker
  • Make idle samples markers closer to the updated timeline background
markers-2

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (0587601) to head (3ae21f8).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/marker-styles.ts 50.00% 4 Missing ⚠️
src/components/timeline/Markers.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5839      +/-   ##
==========================================
- Coverage   85.58%   85.57%   -0.01%     
==========================================
  Files         320      320              
  Lines       31450    31468      +18     
  Branches     8571     8662      +91     
==========================================
+ Hits        26915    26929      +14     
- Misses       4104     4108       +4     
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstange mstange merged commit 743f422 into firefox-devtools:main Feb 14, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the dark mode timeline markers contrast

2 participants