Skip to content

Directly use photon-colors#5821

Merged
mstange merged 1 commit intofirefox-devtools:mainfrom
arai-a:photon-colors-dependency
Feb 14, 2026
Merged

Directly use photon-colors#5821
mstange merged 1 commit intofirefox-devtools:mainfrom
arai-a:photon-colors-dependency

Conversation

@arai-a
Copy link
Contributor

@arai-a arai-a commented Feb 8, 2026

Fixed #5820

This removes a cached copy of photon colors inside the colors.ts, and let it directly use the photon-colors module.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.55%. Comparing base (3ae21f8) to head (ca86724).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5821      +/-   ##
==========================================
- Coverage   85.57%   85.55%   -0.03%     
==========================================
  Files         320      320              
  Lines       31468    31415      -53     
  Branches     8662     8662              
==========================================
- Hits        26929    26876      -53     
  Misses       4108     4108              
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arai-a arai-a force-pushed the photon-colors-dependency branch from 0c56b8e to ca86724 Compare February 14, 2026 16:31
Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, sorry I missed this!

@mstange mstange merged commit cbc013b into firefox-devtools:main Feb 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate definitions of photon colors

2 participants