Provide correct instructions on the home page for Firefox for Android (Fenix)

[fatadel]

Closes #2654.

Before

After

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.58%. Comparing base (0587601) to head (9ad1498).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/components/app/Home.tsx	88.88%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5816   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files         320      320           
  Lines       31450    31459    +9     
  Branches     8571     8662   +91     
=======================================
+ Hits        26915    26924    +9     
  Misses       4104     4104           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[canova]

Thanks for the PR!

I see that the first paragraph is saying that the profiling requires Firefox desktop, but in the second paragraph we tell them that they can also use the on device profiling. I think it would confuse our users. The old wording from the issue was actually suggested before we supported on device profiling, so it's not up-to-date anymore. See also my suggestions below.

[canova]

Ah, it looks like we have 2 different instructions now that kinda say the opposite things. Since we have a Localized component below that says it's possible to profile on an Android device, "Recording performance profiles currently requires Firefox for Desktop" is no longer true. Can we move the android on device profiling above, and add the remote profiling instruction below?

For the wording of remote profiling, maybe something like:

You can also profile Firefox for Android remotely from a desktop
computer. For more information, please consult this documentation:{' '}
<a>Profiling Firefox for Android remotely</a>.

[canova]

This wording is more suitable for the desktop message, since it says "You can also profile Firefox for Android.". Instead, I would prefer to have a new ftl key with a better wording suited specifically for Firefox for Android.

Maybe something like:

Firefox for Android can be profiled directly on this device. For
more information, please consult this documentation:{' '}
<a>Profiling Firefox for Android directly on device</a>.

[fatadel]

Thanks for the valuable review, @canova! I've now incorporated your feedback. Please, re-review when you have a chance 😌

[flodolo]

Can probably simplify?

    { -firefox-android-brand-name } can be profiled directly on this device. For
    more information, read <a>Profiling { -firefox-android-brand-name } directly on device</a>.

[fatadel]

Good for me, wdyt @canova?

[canova]

Sorry missed the ping. Looks great to me!

[fatadel]

@canova no worries. This is done now. Can I have an approval, please? 😌 (or suggestions/questions if any)

[canova]

Thanks for the PR! Looks good to me!

A nit: Could you please update the PR title to explain the PR a bit better. Currently "Refine message on fenix" is a bit blurry to me (and maybe we can remove the issue number). These titles go directly to the release notes, so it's usually a good habit to explain it well.

[canova]

nit: Can you also change the fallback text to lowercase "desktop" to keep it up-to-date with the ftl file?

[fatadel]

Thanks for pointing to this, I've missed it!

[fatadel]

Thanks for the PR! Looks good to me!

A nit: Could you please update the PR title to explain the PR a bit better. Currently "Refine message on fenix" is a bit blurry to me (and maybe we can remove the issue number). These titles go directly to the release notes, so it's usually a good habit to explain it well.

Oh sorry about that, apparently it comes from my branch name. I've taken it into account for the future!