Migrate Home page animation to CSS transitions and remove react-transition-group#5649
Open
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
Open
Migrate Home page animation to CSS transitions and remove react-transition-group#5649mstange wants to merge 2 commits intofirefox-devtools:mainfrom
mstange wants to merge 2 commits intofirefox-devtools:mainfrom
Conversation
b982295 to
b91bec5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5649 +/- ##
==========================================
- Coverage 85.44% 85.38% -0.07%
==========================================
Files 321 322 +1
Lines 32072 32099 +27
Branches 8837 8840 +3
==========================================
+ Hits 27405 27408 +3
- Misses 4236 4260 +24
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b91bec5 to
7018717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main branch | Deploy preview
This removes our usage of react-transition-group. We were only using it for the horizontal slide-in animation that occurs on the home page when we have a WebChannel and detect that the profiler button is in the toolbar.