Use correct path to rtree libraries#16
Merged
connorjward merged 2 commits intofiredrakeproject:mainfrom Mar 26, 2026
Merged
Conversation
connorjward
requested changes
Mar 25, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
We should set a minimum version of rtree here too.
I can make a patch release when this is merged.
connorjward
approved these changes
Mar 26, 2026
Contributor
|
Are you happy for this to be merged? I'm lazy so I'll hold off on making a patch release straight away. Instead point |
Contributor
Author
|
@connorjward I'm happy for this to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rtreechanged their project name to use a lowercase r some time ago: Toblerity/rtree#350Firedrake test running here: firedrakeproject/firedrake#4981