Add static to functions defined in library header.#14
Merged
connorjward merged 2 commits intofiredrakeproject:mainfrom Aug 18, 2025
Merged
Add static to functions defined in library header.#14connorjward merged 2 commits intofiredrakeproject:mainfrom
connorjward merged 2 commits intofiredrakeproject:mainfrom
Conversation
connorjward
approved these changes
Aug 1, 2025
Contributor
|
Thanks this makes sense. I need to fix CI before this goes in but this should be fine. |
Contributor
|
That's now done. Can you merge in the latest |
Contributor
Author
|
@connorjward Done! Thanks! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When including "libsupermesh-c.h" in several *.c files, the linker raises a "multiple definition" error for
libsupermesh_max_n_tris_candlibsupermesh_max_n_tets_c. In fact these functions are defined (and not just declared) in the header, so they do get defined multiple times when the header is included in different *.c files.This patch proposes to solve this by adding
statickeyword to restrict the visibility of these function only to the current translation unit.