Skip to content

Check that the mesh has a boundary before trying to apply a BC to it #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjward merged 1 commit into from
Apr 13, 2026
+10 −4
Merged

Check that the mesh has a boundary before trying to apply a BC to it #5014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions firedrake/slate/static_condensation/hybridization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import ufl

import firedrake.dmhooks as dmhooks
import pyop2
from firedrake.slate.static_condensation.sc_base import SCBase
from firedrake.matrix_free.operators import ImplicitMatrixContext
from firedrake.petsc import PETSc
Expand Down Expand Up @@ -184,10 +185,15 @@ def initialize(self, pc):
else:
# No bcs were provided, we assume weak Dirichlet conditions.
# We zero out the contribution of the trace variables on
# the exterior boundary. Extruded cells will have both
# horizontal and vertical facets
trace_subdomains = ["on_boundary"]
if mesh_unique.cell_set._extruded:
# the exterior boundary. We don't need to do this for boundary-less
# domains (like a sphere).
trace_subdomains = []
with pyop2.mpi.temp_internal_comm(mesh_unique.comm) as icomm:
num_exterior_facets = icomm.allreduce(mesh_unique.exterior_facets.set.size)
if num_exterior_facets > 0:
trace_subdomains.append("on_boundary")
# Extruded cells will have both horizontal and vertical facets
if mesh_unique.cell_set._extruded and not mesh_unique.cell_set._extruded_periodic:
trace_subdomains.extend(["bottom", "top"])
trace_bcs = [DirichletBC(TraceSpace, 0, subdomain) for subdomain in trace_subdomains]

Expand Down
Loading