Open
Conversation
Contributor
Author
|
I don't think any of the test failures are relevant to this change. |
Contributor
|
Yeah looks like https://gitlab.com/petsc/petsc/-/merge_requests/8990 broke some things. |
connorjward
approved these changes
Feb 25, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I'll hold off on merging this until the CI fixes are in, but this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3655
Description
Thank you for keeping
to_petsc_local_numberingaround despite no one else needing it (as far as I'm aware). We have now added this interface to Animate (mesh-adaptation/animate#226) so no longer need it to be in Firedrake.