Fix deadlock when the compiler crashes internally#4913
Open
connorjward wants to merge 4 commits intoreleasefrom
Open
Fix deadlock when the compiler crashes internally#4913connorjward wants to merge 4 commits intoreleasefrom
connorjward wants to merge 4 commits intoreleasefrom
Conversation
* Prevent compiler errors from causing a deadlock * Disable -ffast-math for GCC to fix internal compiler error on CI runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #4819
What happened
In #4911 I have been investigating a very tricky timeout bug. I finally tracked it down to the following compiler error:
This would only happen on the CI runners. On my workstation with the same Docker image things ran fine. Disabling fast math fixes it.