Draft
Conversation
6c79c43 to
70f5212
Compare
70f5212 to
d8c498f
Compare
rckirby
requested changes
Feb 25, 2026
Contributor
rckirby
left a comment
There was a problem hiding this comment.
This is a great idea -- it looks like user just adds a new option to the dictionary if we want to turn it on?
Probably we should have some minimal simple tests, such as parameterizing existing tests of ASMStarPC and ASMVankaPC to turn the coloring option off and on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables ASMStarPC and ASMVankaPC to group patches by color (non-overlapping vertex/Vanka-stars) into a block diagonal matrix. Coloring is enabled through the petsc option
-pc_star_coloring.As a benchmark consider the Poison equation on a 256x256 mesh solved with one process:
Here all solvers are mathematically equivalent, and all of them except TinyASM use Cholmod for the Cholesky factorization of the patch matrices.
Depends on https://gitlab.com/petsc/petsc/-/merge_requests/9069