fix: FIR-51861 null pointer when hydrating null struct#161
Merged
bogdantruta-firebolt merged 1 commit intoJan 14, 2026
Merged
Conversation
|
goprean
approved these changes
Jan 14, 2026
bogdantruta-firebolt
deleted the
FIR-51861-node-sdk-issue-with-struct-with-null-values
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing a result set containing structs, we checked the keys inside the struct value against the ones from the meta, but we never checked if the actual value was null, so
if (Object.keys(innerTypes).length !== Object.keys(value).length) { return value; }was throwing an exception when doingObject.keys(value).length. We fix this by either doingvalue ?? {}or the null check beforehand which I opted for