Add Support for Firebolt Core#152
Merged
Merged
Conversation
wagjamin
commented
Dec 14, 2025
Contributor
Author
There was a problem hiding this comment.
Diff is not shown in a nice way here, all of this just got refactored and moved to managed.ts
wagjamin
commented
Dec 14, 2025
| * For managed Firebolt connections, this is always defined. | ||
| * For Firebolt Core connections, accessing this will throw an error. | ||
| */ | ||
| get resourceManager(): ResourceManager { |
Contributor
Author
There was a problem hiding this comment.
This should make sure that this isn't a breaking change in the library API. You can still call client.resourceManager in the new version, it just fails for Core.
Making the resourceManager itself optional would cause a breaking change.
wagjamin
commented
Dec 14, 2025
goprean
reviewed
Dec 15, 2025
goprean
left a comment
goprean
left a comment
There was a problem hiding this comment.
Few comments, otherwise looks good to me.
Jeseeq
reviewed
Dec 15, 2025
Contributor
bogdantruta-firebolt
left a comment
bogdantruta-firebolt
left a comment
There was a problem hiding this comment.
I am not sure I am ready to tackle the rest of the PR now, but I'll try later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Firebolt Core in our Node SDK. Core is often used in CI/testing pipelines. Having wider SDK support is great as it makes it easier for users to write tests using Core with their custom software.
Note that I'm not a Typescript expert. The diff is large, but most of it is tests. The change contains:
One thing I'd be very curious about, my changes to
src/http/node.tsseem far too complex. This much code just to make HTTP work (HTTPs is default right now, but Core doesn't support it). Would love a detailed review/feedback here on how we can make this easier.