Skip to content

Auto-update dependencies.#680

Open
dpebot wants to merge 1 commit intomasterfrom
dpebot-repositorygardener
Open

Auto-update dependencies.#680
dpebot wants to merge 1 commit intomasterfrom
dpebot-repositorygardener

Conversation

@dpebot
Copy link
Copy Markdown
Collaborator

@dpebot dpebot commented May 9, 2026

Brought to you by your friendly Repository Gardener.

@dpebot dpebot added the automerge Summon MOG for automerging label May 9, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the kotlinx-coroutines-reactive dependency from version 1.10.2 to 1.11.0. The review feedback highlights a potential risk of binary incompatibility when updating coroutines modules individually and suggests using the kotlinx-coroutines-bom to maintain version consistency across the project.


// For streaming callable Cloud Functions
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.10.2")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.11.0")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating kotlinx-coroutines-reactive to 1.11.0 in isolation can lead to binary incompatibility and runtime crashes. All kotlinx-coroutines modules (such as core, android, and reactive) must be kept on the same version to ensure stability. Since this is an Android project, kotlinx-coroutines-android is likely present as a transitive dependency (e.g., via Lifecycle KTX). It is highly recommended to use the kotlinx-coroutines-bom to ensure version consistency across all coroutines modules.

    implementation(platform("org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.11.0"))
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-reactive")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Summon MOG for automerging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant