Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the kotlinx-coroutines-reactive dependency from version 1.10.2 to 1.11.0. The review feedback highlights a potential risk of binary incompatibility when updating coroutines modules individually and suggests using the kotlinx-coroutines-bom to maintain version consistency across the project.
|
|
||
| // For streaming callable Cloud Functions | ||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.10.2") | ||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-reactive:1.11.0") |
There was a problem hiding this comment.
Updating kotlinx-coroutines-reactive to 1.11.0 in isolation can lead to binary incompatibility and runtime crashes. All kotlinx-coroutines modules (such as core, android, and reactive) must be kept on the same version to ensure stability. Since this is an Android project, kotlinx-coroutines-android is likely present as a transitive dependency (e.g., via Lifecycle KTX). It is highly recommended to use the kotlinx-coroutines-bom to ensure version consistency across all coroutines modules.
implementation(platform("org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.11.0"))
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-reactive")
Brought to you by your friendly Repository Gardener.