chore(py): Clean up Python engdocs and samples folders#4908
Draft
huangjeff5 wants to merge 32 commits intomainfrom
Draft
chore(py): Clean up Python engdocs and samples folders#4908huangjeff5 wants to merge 32 commits intomainfrom
huangjeff5 wants to merge 32 commits intomainfrom
Conversation
github-actions
bot
added
docs
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a major internal architectural refactoring of the Genkit Python SDK. The primary goal was to enhance the clarity, maintainability, and type safety of the codebase by reorganizing modules, introducing a consistent base model for data structures, and streamlining the public API. These changes lay a stronger foundation for future development and improve the overall developer experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a major and much-needed cleanup of the Python documentation and sample applications. The simplification of READMEs, reorganization of samples into feature-focused directories, and removal of boilerplate code like run.sh and _common.sh significantly improve the developer experience. The changes are consistent and well-executed. I've found one issue regarding missing imports in a newly added sample file, which should be a straightforward fix. Overall, this is an excellent refactoring that makes the project more maintainable and easier for newcomers to navigate.
| from genkit import Genkit, Message | ||
| from genkit.plugins.google_genai import GeminiConfigSchema, GoogleAI | ||
|
|
||
| if 'GEMINI_API_KEY' not in os.environ: |
Contributor
There was a problem hiding this comment.
The display_code_execution function uses CustomPart, TextPart, and PartConverter, but these are not imported in the file. This will cause a NameError when the function is called. Please add the required imports to make the helper function runnable.
Suggested change
| if 'GEMINI_API_KEY' not in os.environ: | |
| from genkit.plugins.google_genai import GeminiConfigSchema, GoogleAI | |
| from genkit._core._typing import CustomPart, TextPart | |
| from genkit.plugins.google_genai.models.utils import PartConverter |
An error occurred while trying to automatically change base from
jh-redesign
to
main
March 13, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.