Skip to content

fix(js/plugin/compat-oai): Fix type overload shadowing bug for OpenAI models with specific suffixes #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7hokerz wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −8
Open

fix(js/plugin/compat-oai): Fix type overload shadowing bug for OpenAI models with specific suffixes #4263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d17b179
fix(js/plugin/compat-oai): type overload bug for OpenAI models
7hokerz Jan 25, 2026
d461482
fix(js/testapps/compat-oai): update TTS voice 'sage' to 'alloy' to re…
7hokerz Jan 25, 2026
f02fcb1
Merge branch 'firebase:main' into 7hokerz/compat-oai-type-overload-sh…
7hokerz Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions js/plugins/compat-oai/src/openai/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,6 @@ export function openAIPlugin(options?: OpenAIPluginOptions): GenkitPluginV2 {

export type OpenAIPlugin = {
(params?: OpenAIPluginOptions): GenkitPluginV2;
model(
name:
| keyof typeof SUPPORTED_GPT_MODELS
| (`gpt-${string}` & {})
| (`o${number}` & {}),
config?: z.infer<typeof OpenAIChatCompletionConfigSchema>
): ModelReference<typeof OpenAIChatCompletionConfigSchema>;
model(
name:
| keyof typeof SUPPORTED_IMAGE_MODELS
Expand All @@ -272,6 +265,13 @@ export type OpenAIPlugin = {
| (`${string}-transcribe` & {}),
config?: z.infer<typeof TranscriptionConfigSchema>
): ModelReference<typeof TranscriptionConfigSchema>;
model(
name:
| keyof typeof SUPPORTED_GPT_MODELS
| (`gpt-${string}` & {})
| (`o${number}` & {}),
config?: z.infer<typeof OpenAIChatCompletionConfigSchema>
): ModelReference<typeof OpenAIChatCompletionConfigSchema>;
model(name: string, config?: any): ModelReference<z.ZodTypeAny>;
embedder(
name:
Expand Down
2 changes: 1 addition & 1 deletion js/testapps/compat-oai/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ ai.defineFlow(
const { media } = await ai.generate({
model: openAI.model('gpt-4o-mini-tts'),
config: {
voice: 'sage',
voice: 'alloy',
},
prompt: query,
});
Expand Down