Skip to content

fix(tests): resolve failing tests in CI #18287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SelaseKay wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Draft

fix(tests): resolve failing tests in CI #18287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ void main() {
await Future.delayed(const Duration(seconds: 2));
},
skip: defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows ||
defaultTargetPlatform == TargetPlatform.windows
// TODO(SelaseKay): this is crashing iOS app when running on CI
defaultTargetPlatform == TargetPlatform.iOS,
// defaultTargetPlatform == TargetPlatform.iOS,
);

test(
Expand Down Expand Up @@ -902,8 +902,7 @@ void main() {
},
// TODO(SelaseKay): this needs to be investigated as now failing on android
skip: defaultTargetPlatform == TargetPlatform.iOS ||
defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.android,
defaultTargetPlatform == TargetPlatform.macOS,
);
});

Expand Down
2 changes: 1 addition & 1 deletion tests/integration_test/firebase_database/firebase_database_configuration_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ void setupConfigurationTests() {
}
},
// TODO(SelaseKay): this needs to be investigated as now failing on android (should only run on android)
skip: true,
skip: defaultTargetPlatform != TargetPlatform.android,
);
});
}
Loading