feat(auth): onUpgradeFailure callback when account linking fails#1355
Open
russellwheatley wants to merge 6 commits intomainfrom
Open
feat(auth): onUpgradeFailure callback when account linking fails#1355russellwheatley wants to merge 6 commits intomainfrom
russellwheatley wants to merge 6 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an onUpgradeFailure callback to the anonymous upgrade behaviors, allowing for custom error handling and suppression during the linking process. The changes include new type definitions, a centralized error handling utility, and updated logic for both credential and provider linking handlers. A critical issue was identified in the provider linking implementation where the unconditional removal of the user ID from local storage in a finally block would disrupt the redirect flow.
Member
Author
|
I think I'd like to get some integration tests setup for this before going further with this PR as there are some changes to core behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onUpgradeFailurecallback for anonymous user auto-upgrade failures."handled".closes #1354
Below demonstrates
onUpgradeFailurefiring when auto upgrade anonymous user fails and also returns "handled" so error message does not appear in the UI.Screen.Recording.2026-05-07.at.16.47.44.mov