Adding dataconnect:compile command #9727
Conversation
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new dataconnect:compile command. This command provides a way to compile Data Connect services, which includes building schemas and connectors and generating typed SDKs. The implementation correctly reuses existing logic from the deploy and SDK generation commands. My review includes a couple of suggestions to improve the clarity and correctness of the new command's implementation, such as updating the command description to be more comprehensive and clarifying a parameter passed to a shared function.
| type CompileOptions = Options & { service?: string; location?: string }; | ||
|
|
||
| export const command = new Command("dataconnect:compile") | ||
| .description("compile your Data Connect schema and connector config and GQL files.") |
There was a problem hiding this comment.
The command's description is slightly incomplete. In addition to compiling schema and connector files, the command also generates typed SDKs via DataConnectEmulator.generate. To avoid user surprise and accurately reflect the command's full functionality, I recommend updating the description.
| .description("compile your Data Connect schema and connector config and GQL files.") | |
| .description("compile your Data Connect schema and connector config, generate GQL files, and generate typed SDKs.") |
| buildResult.errors, | ||
| options.nonInteractive, | ||
| options.force, | ||
| !!options.dryRun, |
There was a problem hiding this comment.
For clarity and to avoid potential confusion, it's better to pass false directly for the dryRun parameter, as this command doesn't support a --dry-run option. Using !!options.dryRun could be misleading for future maintenance, as it implies that dryRun might be a valid property on the options object.
| !!options.dryRun, | |
| false, |
1 participant
Description
Adding
dataconnect:compilecommand, as described in go/fdc-compile