feat(ai): template chat and function calling api#9742
feat(ai): template chat and function calling api#9742cynthiajoan wants to merge 3 commits intofirebase:mainfrom
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AI SDK by introducing robust support for server-side template-based chat sessions. It provides a dedicated class for managing conversational history and integrates automatic function calling capabilities, enabling more dynamic and interactive AI experiences. The changes extend the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces TemplateChatSession and related types to enable chat functionality with server-side templates, including automatic function calling. The TemplateChatSession class manages chat history and handles both streaming and non-streaming message exchanges. Key changes include defining StartTemplateChatParams and TemplateFunctionDeclaration for template-specific configurations and tools. Review feedback highlights a critical bug where parallel function calls with the same name might be overwritten due to the use of a Map in _callFunctionsAsNeeded. Additionally, there's a typo in maxSequentalFunctionCalls that needs correction, duplicated logic for finding functionDeclarationsTool, and a missing id in FunctionResponse that could impact call correlation. A redundant export of TemplateChatSession was also noted.
packages/ai/src/index.ts
Outdated
| export * from './api'; | ||
| export * from './public-types'; | ||
| export { LiveChatSession } from './methods/live-session'; | ||
| export { TemplateChatSession } from './methods/template-chat-session'; |
| const functionDeclarationsTool = this.params.tools?.find( | ||
| (tool: object) => | ||
| (tool as TemplateFunctionDeclarationsTool).functionDeclarations | ||
| ) as TemplateFunctionDeclarationsTool; |
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
PR that changes the public API, we would suggest first proposing your change in an
issue so that we can discuss it together.