Skip to content

feat(firestore): Add expressions ifNull and coalesce#15989

Merged
milaGGL merged 7 commits intomainfrom
mila/ifnull-coalesce
Mar 30, 2026
Merged

feat(firestore): Add expressions ifNull and coalesce#15989
milaGGL merged 7 commits intomainfrom
mila/ifnull-coalesce

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Mar 26, 2026

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@milaGGL
Copy link
Copy Markdown
Contributor Author

milaGGL commented Mar 27, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Pipeline expressions ifNull and coalesce to the Firestore Swift SDK, including the necessary implementation and integration tests. I have reviewed the changes and the documentation parameter name for coalesce should be updated to match the function signature.

Comment thread Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/Expression.swift Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/Expression.swift Outdated
Copy link
Copy Markdown
Contributor

@yvonnep165 yvonnep165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me except the minor suggested formatting fix and the coalesce test fails as it hasn't been pushed to prod at this moment

@milaGGL milaGGL merged commit 382c9a6 into main Mar 30, 2026
69 of 74 checks passed
@milaGGL milaGGL deleted the mila/ifnull-coalesce branch March 30, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants