fix: Remove false warning when using Expression in cors option

[HassanBahati]

Description

Fixes #1715

Changed the internal CORS processing to use .runtimeValue() instead of .value() when extracting values from Expression objects. The .runtimeValue() method appears to be the correct internal API for this use case and doesn't emit warnings.

[gemini-code-assist]

Summary of Changes

Hello @HassanBahati, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a false warning was generated when Expression objects were used to configure CORS options in Firebase Functions. The fix involves updating the internal API call from .value() to .runtimeValue() for Expression objects, which is the correct method for runtime evaluation and prevents the unnecessary warning. This change improves the developer experience by eliminating misleading warnings and ensures proper handling of dynamic CORS configurations.

Highlights

• CORS Expression Handling: Corrected the internal CORS processing to use .runtimeValue() instead of .value() when extracting values from Expression objects. This resolves a false warning previously emitted when using dynamic CORS configurations.
• Test Coverage: Added new test cases for onRequest and onCall functions to explicitly verify that no warnings are logged when using Expression-based CORS configurations during deployment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where using an Expression for the cors option would trigger a false warning. The fix involves switching from .value() to .runtimeValue() to resolve the expression, which is the correct approach for this use case. The changes are applied to both onRequest and onCall functions, ensuring consistency. New tests have been added to verify that the warning is no longer present, which is great. I have one suggestion regarding the new tests to improve code maintainability by reducing duplication. Overall, this is a solid fix.

[HassanBahati]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively resolves an issue where using an Expression in the cors option for HTTPS functions would trigger a false warning. The fix correctly replaces .value() with .runtimeValue() to get the expression's value, which is the appropriate internal API for this context and avoids the unnecessary warning.

The change is consistently applied to both onRequest and onCall functions. I appreciate the addition of a new test helper function and new test cases that specifically verify this fix, ensuring that no warnings are logged under deployment-like conditions. The tests are well-written and provide good coverage for the change.

Overall, this is a clean and well-executed fix. The code quality is high, and I have no further suggestions. Great work!