fix(v1): Call onInit for schedule.onRun functions

[HassanBahati]

Description

Description

Fixes #1680

When creating a V1 scheduled function using functions.pubsub.schedule().onRun(), the onInit callback was never executed. This was caused by scheduled functions (identified by the deployment-scheduled label) using the unwrapped contextOnlyHandler instead of the withInit-wrapped version.

Solution

Added a separately wrapped version of contextOnlyHandler so that scheduled functions also execute any registered onInit callbacks:

• Created wrappedContextOnlyHandler by wrapping contextOnlyHandler with withInit
• Changed scheduled function execution to use wrappedContextOnlyHandler instead of the unwrapped contextOnlyHandler

[gemini-code-assist]

Summary of Changes

Hello @HassanBahati, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in V1 scheduled functions where the onInit callback was not being invoked. By introducing a withInit-wrapped version of the context-only handler and updating scheduled function execution to use it, this change ensures that all necessary initialization logic is consistently run for scheduled tasks. This improves the reliability and expected behavior of scheduled functions within the Firebase ecosystem.

Highlights

• Fix for onInit in Scheduled Functions: This PR resolves an issue where the onInit callback was not being executed for V1 scheduled functions created using functions.pubsub.schedule().onRun().
• Introduction of wrappedContextOnlyHandler: A new wrappedContextOnlyHandler has been introduced, which is the contextOnlyHandler wrapped with withInit, specifically to ensure onInit execution for scheduled functions.
• Scheduled Function Handler Update: The logic for scheduled functions (identified by the deployment-scheduled label) has been updated to utilize the new wrappedContextOnlyHandler, ensuring onInit callbacks are triggered correctly.
• New Test Case Added: A new test has been added to spec/v1/providers/pubsub.spec.ts to explicitly verify that onInit is called before the execution of a scheduled function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the issue where onInit callbacks were not being executed for V1 scheduled functions. The solution involves wrapping the contextOnlyHandler with withInit for scheduled functions, ensuring that initialization logic runs as expected. A new, comprehensive test case has been added to pubsub.spec.ts to verify this fix, which is a good practice. The changes are clear, concise, and directly resolve the reported bug.